BordedDev
  • Joined on 2025-01-11
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:51:52 +00:00
Sudoku review

Nice usage of the coercion, even if my IDE complains because there is coercion

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:49:25 +00:00
Sudoku review

A double filter, it's inefficient (since both will loop through the array) but for the size it doesn't really matter

BordedDev pushed to main at BordedDev/sudoku 2025-01-16 21:45:56 +00:00
777573e71d Fixed type parameter
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:41:57 +00:00
Sudoku review

@BordedDev nice review so far! I will check your new files tomorrow. I'm now fighting with speech recognition and command execution. It's a cool project and it was open source for a while but…

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:26:53 +00:00
Sudoku review

Dang it I missed it, it's meant to be SUDOKU_GRID_SIZE. You did with the new Puzzle(9)

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:21:46 +00:00
Sudoku review

Never! Google can claw my faux-privacy from my cold dead hands (also ublock)

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:20:24 +00:00
Sudoku review

Still better than my junior. I was very surprised, learning about the CSS upgrade this year

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:19:13 +00:00
Sudoku review

It's here: https://developer.mozilla.org/en-US/docs/Web/API/Web_components/Using_custom_elements

In the class constructor, you can set up initial state and default values, register event…

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 20:01:01 +00:00
Sudoku review

Accidental comparison 😅

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:58:10 +00:00
Sudoku review

Var :(

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:56:48 +00:00
Sudoku review

Simplified the empty event handler assignment

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:52:49 +00:00
Sudoku review

From what I've read, it's not recommended to create elements in the constructor and instead should be done in the connectedCallback

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:51:29 +00:00
Sudoku review

Not sure if the double border was intentional, I assume it wasn't.

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:48:36 +00:00
Sudoku review

You can combine styles as well, I find it to be a bit easier to work with on average since you can toggle and combine them when it's needed much easier.

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:46:19 +00:00
Sudoku review

Unfortunately, this doesn't work with dynamic inside out sizing/nested aspect-ration on firefox. Luckily, you can use em since the size is based on font size

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:31:19 +00:00
Sudoku review

Why are there 2 initialized properties?

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:29:38 +00:00
Sudoku review

Seeing someone implement a custom toString is always nice

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:27:07 +00:00
Sudoku review

The Row/Col classes are confusing in the current situation, since Row isn't used for more than a bag holder/event forwarding

BordedDev commented on pull request retoor/sudoku#1 2025-01-15 19:17:00 +00:00
Sudoku review

A pretty standard, pretty robust way of handling events. I'd lean to the built-in EventTarget until the need for something better is needed.

BordedDev created pull request retoor/sudoku#1 2025-01-14 22:24:29 +00:00
WIP: Sudoku review