BordedDev
  • Joined on 2025-01-11
BordedDev pushed to main at BordedDev/sudoku 2025-01-17 00:01:31 +00:00
cfa484c6c3 Removed extra variable
BordedDev pushed to main at BordedDev/sudoku 2025-01-17 00:00:00 +00:00
b3cfeea045 Removed a line to help with aligning previous comments
BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:59:09 +00:00
17bd0429f1 Added def for undefined and null on SudokuState
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:57:32 +00:00
Sudoku review

This mainly to enforce that the underlying grid isn't modifiable, technically we return a new array anyway, so there is little point. #activeState is also always replaced so we can freeze it when it's created, but this felt more flexible

BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:55:38 +00:00
46f0434852 Added readonly doc
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:51:24 +00:00
Sudoku review

This contains a stack of states, essentially the initial state + all steps

BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:50:45 +00:00
2edeb893a4 Added typedef for SudokuStates
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:45:30 +00:00
Sudoku review

Type hints are here since I can see them in my IDE and make things slightly easier to work with, hence why I've put them everywhere but with no actual docs

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:43:44 +00:00
Sudoku review

This is to fix the vertical alignment since it had a value of 1.5 for me

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:40:04 +00:00
Sudoku review

This is mostly personal preference, since an "industry standard" way would be key => action enum => (action transform) => action function. I find this a bit easier to read. If I'd bring in a library for the matching I'd have used cond from lodash https://lodash.com/docs/4.17.15#cond

BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:35:29 +00:00
48e0e90caa Removed potential fix for aspect ratio (that didn't work)
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:29:38 +00:00
Sudoku review

Collapsed the index to come from the matches array, since I noted the 1-to-1 relation

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:28:24 +00:00
Sudoku review

Switched .forEach to for of loop for performance (recommended practice, but honestly, it’s not a big deal - I'd even call it a nitpick)

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:25:04 +00:00
Sudoku review

A lot of these me proxies aren't necessary with the arrow functions you're using, they're removed in the modified version

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:21:47 +00:00
Sudoku review

I ran Biome.js over this, and I'm a ; hater (my default config), that's why they're not here

BordedDev commented on pull request retoor/sudoku#1 2025-01-16 23:17:25 +00:00
Sudoku review

I'd normally use a @property for this but it wasn't working the initial value so I did this instead

BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:11:06 +00:00
76dbe00a7f Correct null assigner instead of or assignment
BordedDev pushed to main at BordedDev/sudoku 2025-01-16 23:05:10 +00:00
64c345564a Simplified undefined check
BordedDev pushed to main at BordedDev/sudoku 2025-01-16 22:05:20 +00:00
1868b38219 Fixed extra borders at edges
BordedDev commented on pull request retoor/sudoku#1 2025-01-16 21:59:38 +00:00
Sudoku review

Regex strikes again 🏃💨. Technically inefficient, practically I like it.